Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): Executor framework server and worker proxy #8714

Merged
merged 26 commits into from Nov 2, 2023
Merged

feat(spanner): Executor framework server and worker proxy #8714

merged 26 commits into from Nov 2, 2023

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Oct 13, 2023 •
edited

Executor Framework for Golang spanner client library.

This PR adds code changes for the following

  1. Create a gRPC server and start a cloud proxy server. This enables the server to read incoming requests in the configured port.
  2. Adds input_stream package that handles input requests to the stream from the client.
  3. Adds output_stream package that sends output requests via stream back to the client.
  4. Adds utility package that helps with error conversion, storing table metadata across actions etc.

@harshachinta harshachinta requested review from a team as code owners October 13, 2023 13:19
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the Spanner API. labels Oct 13, 2023
@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 13, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Oct 13, 2023
@harshachinta harshachinta changed the title feat(spanner): Executor framework server and worker proxy feat(spanner): Executor framework proto, server and worker proxy Oct 13, 2023
@harshachinta harshachinta mentioned this pull request Oct 13, 2023
Merged
@harshachinta
Copy link
Contributor Author

harshachinta commented Oct 14, 2023 •
edited

@arpan14 @gyang-google @rahul2393
Can you please review this PR for executor framework?

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Oct 20, 2023
@harshachinta harshachinta changed the title feat(spanner): Executor framework proto, server and worker proxy feat(spanner): Executor framework server and worker proxy Oct 20, 2023
arpan14
arpan14 reviewed Oct 20, 2023
View reviewed changes
spanner/cloudexecutor/worker_proxy.go Outdated Show resolved Hide resolved
spanner/cloudexecutor/worker_proxy.go Outdated Show resolved Hide resolved
spanner/cloudexecutor/worker_proxy.go Outdated Show resolved Hide resolved
spanner/cloudexecutor/worker_proxy.go Outdated Show resolved Hide resolved
spanner/cloudexecutor/executor/cloud_executor.go Outdated Show resolved Hide resolved
@harshachinta harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 20, 2023
@harshachinta harshachinta merged commit 6b931ee into googleapis:main Nov 2, 2023
9 checks passed
@release-please release-please bot mentioned this pull request Nov 2, 2023
Merged
bhshkh pushed a commit that referenced this pull request Nov 3, 2023
@harshachinta @bhshkh
feat(spanner): Executor framework server and worker proxy (#8714)
b4af3bd 
* feat(spanner): add executor code

* feat(spanner): add license headers

* feat(spanner): add proto and autogenerated code

* feat(spanner): add cloud_executor file which has helper methods

* feat(spanner): make code modular

* feat(spanner): move autogenerated protos to a different PR

* feat(spanner): rename file

* feat(spanner): rename

* feat(spanner): use string.join

* feat(spanner): add file responsibility

* feat(spanner): coder refactoring

* feat(spanner): coder refactoring

* feat(spanner): update go.mod

* feat(spanner): lint fixes

* feat(spanner): lint fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpan14 arpan14 arpan14 approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

@gyang-google gyang-google gyang-google approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harshachinta @arpan14 @rahul2393 @gyang-google