Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): Add DML, DQL, Mutation, Txn Actions and Utility methods for executor framework #8976

Merged
merged 11 commits into from
Nov 7, 2023
Merged

feat(spanner): Add DML, DQL, Mutation, Txn Actions and Utility methods for executor framework #8976

merged 11 commits into from
Nov 7, 2023

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Nov 4, 2023 •
edited
Loading

This PR adds the following code for executor framework,

  1. Start and Finish Transaction actions
  2. DML actions
  3. DQL actions
  4. Mutation Actions
  5. Utility methods
    1. Convert executor value to spanner value
    2. Convert spanner value to executor value
    3. Convert executor keys to spanner supported key format

@harshachinta harshachinta requested review from a team as code owners November 4, 2023 12:39
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the Spanner API. labels Nov 4, 2023
@harshachinta harshachinta changed the title feat(spanner): add code for executor framework feat(spanner): Add DML, DQL, Mutation Actions and Utility methods Nov 4, 2023
@harshachinta harshachinta changed the title feat(spanner): Add DML, DQL, Mutation Actions and Utility methods feat(spanner): Add DML, DQL, Mutation Actions and Utility methods for executor framework Nov 4, 2023
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2023
@harshachinta
Copy link
Contributor Author

@gyang-google Can you please review this PR?

@harshachinta harshachinta changed the title feat(spanner): Add DML, DQL, Mutation Actions and Utility methods for executor framework feat(spanner): Add DML, DQL, Mutation, Txn Actions and Utility methods for executor framework Nov 5, 2023
@harshachinta harshachinta merged commit ca76671 into googleapis:main Nov 7, 2023
9 checks passed
@release-please release-please bot mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

@gyang-google gyang-google gyang-google approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harshachinta @rahul2393 @gyang-google @kokoro-team