Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(main): add telemetry discussion to debug.md #9074

Merged
merged 7 commits into from Jan 11, 2024
Merged

docs(main): add telemetry discussion to debug.md #9074

merged 7 commits into from Jan 11, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Dec 4, 2023

@quartzmo quartzmo requested a review from a team as a code owner December 4, 2023 23:18
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 4, 2023
tritone
tritone reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts; we discussed offline but let me know if you have further questions.

debug.md Show resolved Hide resolved
debug.md Outdated Show resolved Hide resolved
debug.md Show resolved Hide resolved
debug.md Outdated Show resolved Hide resolved
debug.md Show resolved Hide resolved
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jan 4, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 11, 2024
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2024
@quartzmo quartzmo merged commit 90ed12e into googleapis:main Jan 11, 2024
8 of 9 checks passed
@quartzmo quartzmo deleted the docs-debug-telemetry branch January 11, 2024 19:20
@release-please release-please bot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone left review comments

@shollyman shollyman shollyman approved these changes

@codyoss codyoss codyoss approved these changes

@hongalex hongalex hongalex approved these changes

@bhshkh bhshkh bhshkh approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. size: l Pull request size is large. stale: old Pull request is old and needs attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@quartzmo @shollyman @tritone @codyoss @hongalex @bhshkh