Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support IncludeFoldersAsPrefixes #9211

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jan 3, 2024

Adds support for IncludeFoldersAsPrefixes to object listing, which allows managed folders to be included in the results.

This is not yet implemented in gRPC so if it's called on a gRPC client then an Unimplemented error is returned.

Adds support for IncludeFoldersAsPrefixes to object listing,
which allows managed folders to be included in the results.

This is not yet implemented in gRPC so if it's called on a
gRPC client then an Unimplemented error is returned.
@tritone tritone requested review from a team as code owners January 3, 2024 18:50
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Jan 3, 2024
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris! Just added a comment on cleanup but otherwise LGTM

storage/integration_test.go Outdated Show resolved Hide resolved
storage/integration_test.go Show resolved Hide resolved
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Jan 23, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 98c9d71 into googleapis:main Jan 23, 2024
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 23, 2024
@tritone tritone deleted the mf-query branch January 24, 2024 00:05
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
This is needed in preparation for google#3381.

googleapis/google-cloud-go#9211 introduced the
`includeFoldersAsPrefixes=false` query string in the URLs.
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
This is needed in preparation for google#3381.

googleapis/google-cloud-go#9211 introduced the
`includeFoldersAsPrefixes=false` query string in the URLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants