fix(pubsub): move flow control release to callback completion #9311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
shollyman
reviewed
Jan 26, 2024
| wg.Add(1) | ||
| // Make sure the subscription has ordering enabled before adding to scheduler. | ||
| var key string | ||
| if s.enableOrdering { | ||
| key = msg.OrderingKey | ||
| } | ||
| // TODO(deklerk): Can we have a generic handler at the | ||
| // constructor level? | ||
| msgLen := len(msg.Data) |
There was a problem hiding this comment.
I'm not super familiar with msg lifecycle here. Is it possible for the user to alter msg.Data between acquire and release, which could cause the flow controller to get out of sync? If so, it might make sense to compute the length once and pass that to acquire and release.
There was a problem hiding this comment.
At this point, the message hasn't been dispatched to the user yet. This is all pre-processing, where the message isn't changed.
shollyman
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the flow control release to the end of the user callback rather than to the message
doneFunc. This further emphasizes the importance of callingackandnackwithin the callback, since callingackin a goroutine could mean that flow control resources are released too early. This behavior is already documentedFixes #9309
Internal issue: 322090131