fix(spanner): SelectAll struct fields match should be case-insensitive #9417
+19
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
olavloite
reviewed
Feb 13, 2024
| @@ -2087,8 +2088,8 @@ func TestSelectAll(t *testing.T) { | |||
| }, | |||
| }, | |||
| want: &[]testStruct{ | |||
| {Col1: 1, Col2: 1.1, Col3: "value", Col4: tm}, | |||
| {Col1: 2, Col2: 2.2, Col3: "value2", Col4: tm.Add(24 * time.Hour)}, | |||
| {Col1: 1, COL2: 1.1, Col3: "value", Col4: tm}, | |||
There was a problem hiding this comment.
Same here also: Should this not be kept as Col2?
There was a problem hiding this comment.
No, this should be COL2, because testStruct is user defined struct and we are asserting that though mock response contained col2 it was successfully decoded in testStruct
There was a problem hiding this comment.
Eh, yeah, I read that wrong. I thought that this was also a mock iterator, but it's clearly not....
rahul2393
added
the
kokoro:force-run
olavloite
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9415
row.ToStruct does case-insensitive match against the Go struct field names using https://pkg.go.dev/cloud.googles.ltd/go/internal/fields#List.Match, others decode methods should also follow the same