Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): SelectAll struct spanner tag annotation match should be case-insensitive #9460

Merged
merged 2 commits into from Feb 23, 2024
Merged

feat(spanner): SelectAll struct spanner tag annotation match should be case-insensitive #9460

merged 2 commits into from Feb 23, 2024
+42 −3

Conversation

yukia3e
Copy link
Contributor

@yukia3e yukia3e commented Feb 23, 2024 •
edited by rahul2393

Fixes #9459

@yukia3e yukia3e requested review from a team as code owners February 23, 2024 04:40
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the Spanner API. labels Feb 23, 2024
@rahul2393 rahul2393 changed the title feat(spanner): SelectAll struct spanner tag annotation match should b… feat(spanner): SelectAll struct spanner tag annotation match should be case-insensitive Feb 23, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@rahul2393
Copy link
Contributor

rahul2393 commented Feb 23, 2024 •
edited

Can you please also update this test https://github.com/googleapis/google-cloud-go/blob/main/spanner/row_test.go#L1997, to have a field where spanner tag is used?

@yukia3e
Copy link
Contributor Author

yukia3e commented Feb 23, 2024

Can you please also update this test https://github.com/googleapis/google-cloud-go/blob/main/spanner/row_test.go#L1997, to have a field where spanner tag is used?

Okay, I'll give it a try.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 23, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@yukia3e
Copy link
Contributor Author

yukia3e commented Feb 23, 2024

@rahul2393
I have added a test and would be happy to check it out. (0ad0aee)

@rahul2393 rahul2393 merged commit 6cd6a73 into googleapis:main Feb 23, 2024
9 checks passed
@release-please release-please bot mentioned this pull request Feb 23, 2024
Merged
@yukia3e yukia3e deleted the fix-selectall-tag-case-insensitive branch February 23, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
3 participants
@yukia3e @rahul2393 @kokoro-team