Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add support of float32 type #9525

Merged
merged 3 commits into from Mar 8, 2024
Merged

feat(spanner): add support of float32 type #9525

merged 3 commits into from Mar 8, 2024

Conversation

rahul2393
Copy link
Contributor

No description provided.

@rahul2393 rahul2393 requested review from a team as code owners March 8, 2024 06:27
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the Spanner API. labels Mar 8, 2024
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor nits (and I added some additional tests)

spanner/value.go Outdated Show resolved Hide resolved
spanner/value.go Outdated Show resolved Hide resolved
spanner/value.go Outdated Show resolved Hide resolved
spanner/value.go Outdated Show resolved Hide resolved
spanner/value.go Outdated Show resolved Hide resolved
@rahul2393 rahul2393 merged commit 87d7ea9 into main Mar 8, 2024
13 checks passed
@rahul2393 rahul2393 deleted the float32-support branch March 8, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants