Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update library generation image tag #10758

Merged
merged 8 commits into from May 3, 2024
Merged

deps: update library generation image tag #10758

merged 8 commits into from May 3, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Apr 27, 2024 •
edited

In this PR:

  • Update library generation image tag to 2.40.0
  • Change docker run command in workflow
  • Update README.md for new client generation

@JoeWang1127
Copy link
Contributor Author

"Verify GAPIC client library generation / generate (pull_request)" still uses new-client.py. I'll remove this workflow in a follow up PR.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review May 3, 2024 13:22
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner May 3, 2024 13:22
@JoeWang1127 JoeWang1127 merged commit 4b2f4c6 into main May 3, 2024
31 of 32 checks passed
@JoeWang1127 JoeWang1127 deleted the deps/update-image-tag branch May 3, 2024 15:05
@JoeWang1127 JoeWang1127 mentioned this pull request May 3, 2024
Closed
@release-please release-please bot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoeWang1127 @blakeli0