Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests - fix intermittent failure: Unexpected method call Logging.close() #1541

Closed
garrettjonesgoogle opened this issue Jan 17, 2017 · 2 comments
Assignees
Labels
api: logging Issues related to the Cloud Logging API.

Comments

@garrettjonesgoogle
Copy link
Member

Tests in error: 
  ITLoggingTest.testListSinksAsync » Logging io.grpc.StatusRuntimeException: INT...

Exception in thread "Thread-0" java.lang.AssertionError: 
  Unexpected method call Logging.close():
    Logging.write([LogEntry{logName=null, resource=null, timestamp=null, severity=DEBUG, insertId=null, httpRequest=null, labels={levelName=FINEST, levelValue=300}, operation=null, payload=StringPayload{type=STRING, data=message}}], WriteOption{name=LOG_NAME, value=java.log}, WriteOption{name=RESOURCE, value=MonitoredResource{type=global, labels={project_id=project}}}): expected: 1, actual: 1
	at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:44)
	at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:94)
	at com.sun.proxy.$Proxy11.close(Unknown Source)
	at com.google.cloud.logging.LoggingHandler.close(LoggingHandler.java:375)
	at java.util.logging.LogManager.resetLogger(LogManager.java:1346)
	at java.util.logging.LogManager.reset(LogManager.java:1332)
	at java.util.logging.LogManager$Cleaner.run(LogManager.java:239)

https://travis-ci.org/GoogleCloudPlatform/google-cloud-java/jobs/191392244
https://travis-ci.org/GoogleCloudPlatform/google-cloud-java/jobs/191530116

@garrettjonesgoogle garrettjonesgoogle added blocking GA api: logging Issues related to the Cloud Logging API. labels Jan 17, 2017
@gregw
Copy link

gregw commented Jan 18, 2017

Note that I have fixed (or at least avoided) this issue in PR #1535 by implemented close to be a noop that avoids calling the mock close.

@garrettjonesgoogle
Copy link
Member Author

Closing out issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Development

No branches or pull requests

2 participants