Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withHostName method in google-cloud-storage requires URI scheme #6361

Closed
houglum opened this issue Sep 26, 2019 · 1 comment · Fixed by #6788
Closed

withHostName method in google-cloud-storage requires URI scheme #6361

houglum opened this issue Sep 26, 2019 · 1 comment · Fixed by #6788
Assignees
Labels
api: storage Issues related to the Cloud Storage API. help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@houglum
Copy link

houglum commented Sep 26, 2019

Method:

* Use a different host name than the default host name 'https://storage.googleapis.com'. This

Despite this being a method to supply the hostname (e.g. storage.googleapis.com), this actually requires that you pass in the entire base URL (e.g. https://storage.googleapis.com). To fix this, I propose that we:

  • Change the method's docstring to suggest passing in only the hostname.
  • Silently support the previous functionality to keep from breaking current users; when parsing the argument, we'd just strip off the scheme portion (http[s]://) if it's present.
@houglum
Copy link
Author

houglum commented Sep 26, 2019

@frankyn Filed this issue after our chat this morning so that we wouldn't forget 👌

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 27, 2019
@chingor13 chingor13 added api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 30, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Oct 1, 2019
@JesseLovelace JesseLovelace added the help wanted We'd love to have community involvement on this issue. label Oct 18, 2019
@athakor athakor self-assigned this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants