feat: [publicca] new module for publicca #8557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
suztomo
commented
Oct 7, 2022
suztomo
commented
- feat: initial generation of publicca
- build: add the publicca module to monorepo
gcf-owl-bot
bot
removed
the
owlbot:run
lqiu96
reviewed
Oct 7, 2022
java-publicca/.OwlBot.yaml
Outdated
Comment on lines
16
to
19
| deep-remove-regex: | ||
| - "/grpc-google-.*/src" | ||
| - "/proto-google-.*/src" | ||
| - "/google-.*/src" |
There was a problem hiding this comment.
Shouldn't this prefixed with /java-publicca?
suztomo
force-pushed
the
new_module_java-publicca
branch
from
4bf3e57
to
941a728
Compare
suztomo
commented
Oct 7, 2022
Comment on lines
+16
to
+22
| deep-remove-regex: | ||
| - "/java-publicca/grpc-google-.*/src" | ||
| - "/java-publicca/proto-google-.*/src" | ||
| - "/java-publicca/google-.*/src" | ||
|
|
||
| deep-preserve-regex: | ||
| - "/java-publicca/google-.*/src/test/java/com/google/cloud/.*/v.*/it/IT.*Test.java" |
There was a problem hiding this comment.
@lqiu96 Fixed. Now they have "/java-publicca" at the beginning.
meltsufin
approved these changes
Oct 8, 2022
| @@ -384,6 +384,10 @@ | |||
| "component": "google-cloud-profiler", | |||
| "skip-github-release": true | |||
| }, | |||
| "java-publicca": { | |||
| "component": "google-cloud-publicca", | |||
| "skip-github-release": true | |||
There was a problem hiding this comment.
What does skip-github-release do?
There was a problem hiding this comment.
Not to create a GitHub release entry for now during the shadow mode.
suztomo
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.