feat: [monitoring-metricsscope] new module for monitoring-metricsscope #8875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
reviewed
Dec 6, 2022
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "api_shortname": "monitoring-metricsscope", | |||
| "name_pretty": "Monitoring Metrics Scopes", | |||
There was a problem hiding this comment.
Should it be "Monitoring Metrics Scope" singular?
| "api_shortname": "monitoring-metricsscope", | ||
| "name_pretty": "Monitoring Metrics Scopes", | ||
| "product_documentation": "https://cloud.google.com/monitoring/api/ref_v3/rest/v1/locations.global.metricsScopes", | ||
| "api_description": "The metrics scope defines the set of Google Cloud projects whose metrics the current Google Cloud project can access.", |
There was a problem hiding this comment.
Should you capitalize "The Monitoring Metrics Scope API defines..."?
There was a problem hiding this comment.
Metrics scope is not an independent Cloud product and thus no need to capitalize. From documentation https://cloud.google.com/monitoring/api/ref_v3/rest/v1/locations.global.metricsScopes
meltsufin
approved these changes
Dec 6, 2022
|
For the words in README, we can update it later b/243411138. (The artifact ID and directory name being consistent is more important) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.