fix: [cloudbuild] remove empty v2.CloudBuild definition #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
changed the title
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Owl bot is regenerating pull request 9077... |
PiperOrigin-RevId: 508723510 Source-Link: googleapis/googleapis@a3748ac Source-Link: googleapis/googleapis-gen@d0365de Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiJkMDM2NWRlYmVkNDMzMWMxNWRkZmE2ZWYyOTA0ZDdkYTBjZGVlNzMyIn0= feat: Client libraries for Cloud Build Repositories (preview) PiperOrigin-RevId: 506886904 Source-Link: googleapis/googleapis@88181f5 Source-Link: googleapis/googleapis-gen@a534d6f Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiJhNTM0ZDZmNGE0MzQ3ZmFhZWU1MjFlMTMwZTk2MDhlOTk4OGYyMDQ3In0=
gcf-owl-bot
bot
force-pushed
the
owl-bot-copy-java-cloudbuild
branch
from
9c199ad
to
232c490
Compare
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
PiperOrigin-RevId: 509865389 Source-Link: googleapis/googleapis@573e7eb Source-Link: googleapis/googleapis-gen@4c03ea4 Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiI0YzAzZWE0NWE3YTJjMjQ3ZDlmNWRkM2I3ZmFkYmVlY2U0Yjg4ZTdkIn0=
gcf-owl-bot
bot
changed the title
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
Edit: missing dependencies need to be added manually to this PR. |
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
emmileaf
reviewed
Feb 16, 2023
Comment on lines
46
to
68
| <profiles> | ||
| <profile> | ||
| <id>java9</id> | ||
| <activation> | ||
| <jdk>[9,)</jdk> | ||
| </activation> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>javax.annotation</groupId> | ||
| <artifactId>javax.annotation-api</artifactId> | ||
| </dependency> | ||
| </dependencies> | ||
| </profile> | ||
| </profiles> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>flatten-maven-plugin</artifactId> | ||
| </plugin> | ||
| </plugins> | ||
| </build> |
There was a problem hiding this comment.
Per #8637, it seems like this block should not have been included in this generated pom?
Logs from failing generation diff / consolidate-config check:
diff --git a/java-cloudbuild/grpc-google-cloud-build-v2/pom.xml b/java-cloudbuild/grpc-google-cloud-build-v2/pom.xml
index 7e[5](https://github.com/googleapis/google-cloud-java/actions/runs/4189619832/jobs/7262150832#step:4:6)[6](https://github.com/googleapis/google-cloud-java/actions/runs/4189619832/jobs/7262150832#step:4:7)1eadc..fe7d400c1 100644
--- a/java-cloudbuild/grpc-google-cloud-build-v2/pom.xml
+++ b/java-cloudbuild/grpc-google-cloud-build-v2/pom.xml
@@ -42,2[8](https://github.com/googleapis/google-cloud-java/actions/runs/4189619832/jobs/7262150832#step:4:9) +42,4 @@
<artifactId>guava</artifactId>
</dependency>
</dependencies>
-
- <profiles>
- <profile>
- <id>java[9](https://github.com/googleapis/google-cloud-java/actions/runs/4189619832/jobs/7262150832#step:4:10)</id>
- <activation>
- <jdk>[9,)</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>javax.annotation</groupId>
- <artifactId>javax.annotation-api</artifactId>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
-
- <build>
- <plugins>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>flatten-maven-plugin</artifactId>
- </plugin>
- </plugins>
- </build>
</project>
\ No newline at end of file
diff --git a/java-cloudbuild/proto-google-cloud-build-v2/pom.xml b/java-cloudbuild/proto-google-cloud-build-v2/pom.xml
index 434422f1c..f22d2eb45 100644
--- a/java-cloudbuild/proto-google-cloud-build-v2/pom.xml
+++ b/java-cloudbuild/proto-google-cloud-build-v2/pom.xml
@@ -34,13 +34,4 @@
<artifactId>guava</artifactId>
</dependency>
</dependencies>
-
- <build>
- <plugins>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>flatten-maven-plugin</artifactId>
- </plugin>
- </plugins>
- </build>
</project>
There was a problem hiding this comment.
Looks like this is a similar issue as #8860 (comment). Manually updating in ff40aa4.
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
blakeli0
approved these changes
Feb 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 509865389
Source-Link: googleapis/googleapis@573e7eb
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4c03ea45a7a2c247d9f5dd3b7fadbeece4b88e7d
Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiI0YzAzZWE0NWE3YTJjMjQ3ZDlmNWRkM2I3ZmFkYmVlY2U0Yjg4ZTdkIn0=
BEGIN_NESTED_COMMIT
chore: [cloudbuild] configure CloudBuild V1 for PHP
PiperOrigin-RevId: 508723510
Source-Link: googleapis/googleapis@a3748ac
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d0365debed4331c15ddfa6ef2904d7da0cdee732
Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiJkMDM2NWRlYmVkNDMzMWMxNWRkZmE2ZWYyOTA0ZDdkYTBjZGVlNzMyIn0=
feat: Client libraries for Cloud Build Repositories (preview)
PiperOrigin-RevId: 506886904
Source-Link: googleapis/googleapis@88181f5
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a534d6f4a4347faaee521e130e9608e9988f2047
Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiJhNTM0ZDZmNGE0MzQ3ZmFhZWU1MjFlMTMwZTk2MDhlOTk4OGYyMDQ3In0=
END_NESTED_COMMIT