fix(speech): increment retry setting values and test timeout values in IT #9188
Conversation
product-auto-label
bot
added
the
api: speech
|
Is this in response to an issue with speech IT flakiness? The nightlies haven't been showing an issue here - but is it showing up elsewhere? |
| @@ -14,7 +14,6 @@ Java idiomatic client for [Cloud Speech][product-docs]. | |||
|
|
|||
| If you are using Maven, add this to your pom.xml file: | |||
|
|
|||
| <!--- {x-version-update-start:google-cloud-speech:released} --> | |||
There was a problem hiding this comment.
@ddixit14 Why is OwlBot removing this?
|
@meltsufin @burkedavison I added context in the description |
|
@diegomarquezp This seems similar to an issue that was reported by a customer in the past: https://github.com/googleapis/java-speech/issues/207. |
| .setInitialRpcTimeout(Duration.ZERO) | ||
| .setRpcTimeoutMultiplier(1.0) | ||
| .setMaxRpcTimeout(Duration.ZERO) | ||
| .setTotalTimeout(Duration.ofDays(1)) |
There was a problem hiding this comment.
This seems like a pretty long timeout.
There was a problem hiding this comment.
I believe the default timeout is set to be 5 min. I think you can probably just double it to 10 minutes and should be fine. There was an issue from the java-doc-samples repo a few weeks ago about a similar LRO issue and the runtime increased from ~4:30min to ~5:30min.
There was a problem hiding this comment.
Using a more reasonable ofHours(1)
There was a problem hiding this comment.
I did not see your suggestion @lqiu96 . Let's try 10 minutes
For resolving the speech IT failures produced in the integration tests of #9171
Example failure log
https://fusion2.corp.google.com/ci/kokoro/prod:cloud-devrel%2Fclient-libraries%2Fjava%2Fgoogle-cloud-java%2Fpresubmit%2Fintegration/activity/80fe9394-262e-47f6-94ad-37354783a7e8/summary