Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [biglake] new module for biglake #9237

Merged
merged 3 commits into from Mar 16, 2023
Merged

feat: [biglake] new module for biglake #9237

merged 3 commits into from Mar 16, 2023

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Mar 16, 2023 •
edited

Generated with:

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=biglake \
  --proto-path=google/cloud/bigquery/biglake \
  --name-pretty="BigLake" \
  --product-docs="https://cloud.google.com/biglake" \
  --api-description="The BigLake API provides access to BigLake Metastore, a serverless, fully managed, and highly available metastore for open-source data that can be used for querying Apache Iceberg tables in BigQuery."

Tracking with: b/273322554

@snippet-bot
Copy link

snippet-bot bot commented Mar 16, 2023 •
edited

Here is the summary of possible violations 😱

There are 79 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 79 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lqiu96
Copy link
Contributor Author

lqiu96 commented Mar 16, 2023

Error: There are 79 possible violations for not having product prefix.

The api_shortname matches the region tag prefix... Going to re-run

@lqiu96 lqiu96 added the snippet-bot:force-run Force snippet-bot runs its logic label Mar 16, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Mar 16, 2023
@lqiu96 lqiu96 requested a review from blakeli0 March 16, 2023 19:12
@lqiu96 lqiu96 merged commit c92a33e into main Mar 16, 2023
@lqiu96 lqiu96 deleted the new_module_java-biglake branch March 16, 2023 23:28
@release-please release-please bot mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@suztomo suztomo Awaiting requested review from suztomo

@meltsufin meltsufin Awaiting requested review from meltsufin

@burkedavison burkedavison Awaiting requested review from burkedavison

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lqiu96 @blakeli0