Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(scc-samples): update comments to include new parent types #9596

Merged
merged 5 commits into from Jul 11, 2023

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Jun 29, 2023

Security Command Center Samples

Contains only comment updates to allow new parent types.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 29, 2023
@Sita04 Sita04 requested a review from suztomo June 29, 2023 21:42
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that the SCC Assets API is deprecated and will be replaced by integrating Cloud Asset Inventory's API in SCC. The CAI replacement is expected to GA at the beginning of August. Existing users have a year to move off of the SCC API. SCC's Assets API is disabled for all new users who activate SCC after last week's deprecation notice. New users can only use CAI.

@Sita04 Sita04 requested a review from bpj146 July 5, 2023 16:30
@Sita04 Sita04 added the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 7, 2023
Copy link

@bpj146 bpj146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments on stuff I missed the first time around

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we start thinking about moving to java-docs-samples?

@Sita04
Copy link
Contributor Author

Sita04 commented Jul 11, 2023

Yes, I'm discussing it with the Java samples team and have created a bug for it: 290775040
Will take up the discussions internally.

@Sita04 Sita04 merged commit 1927bfc into main Jul 11, 2023
30 checks passed
@Sita04 Sita04 deleted the scc-ple-update branch July 11, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blunderbuss: assign Instruct blunderbuss to assign someone samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants