Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cloudbilling] fixed resource_reference for name in GetProjectBillingInfo #9778

Merged
merged 4 commits into from Sep 8, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Aug 23, 2023

  • Regenerate this pull request now.

PiperOrigin-RevId: 563189185

Source-Link: googleapis/googleapis@4967815

Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f06f3e0bc0e16662a264e3ddc2ef39bf7ad93ec
Copy-Tag: eyJwIjoiamF2YS1iaWxsaW5nLy5Pd2xCb3QueWFtbCIsImgiOiI5ZjA2ZjNlMGJjMGUxNjY2MmEyNjRlM2RkYzJlZjM5YmY3YWQ5M2VjIn0=

BEGIN_NESTED_COMMIT
docs: [cloudbilling] update comments
PiperOrigin-RevId: 559241398

Source-Link: googleapis/googleapis@6fe53ad

Source-Link: https://github.com/googleapis/googleapis-gen/commit/11b03ab6f9cf00cbcd1671af7f5d71348f256a74
Copy-Tag: eyJwIjoiamF2YS1iaWxsaW5nLy5Pd2xCb3QueWFtbCIsImgiOiIxMWIwM2FiNmY5Y2YwMGNiY2QxNjcxYWY3ZjVkNzEzNDhmMjU2YTc0In0=
END_NESTED_COMMIT

Fixes: googleapis/sdk-platform-java#1780

PiperOrigin-RevId: 559241398

Source-Link: googleapis/googleapis@6fe53ad

Source-Link: googleapis/googleapis-gen@11b03ab
Copy-Tag: eyJwIjoiamF2YS1iaWxsaW5nLy5Pd2xCb3QueWFtbCIsImgiOiIxMWIwM2FiNmY5Y2YwMGNiY2QxNjcxYWY3ZjVkNzEzNDhmMjU2YTc0In0=
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review August 23, 2023 01:06
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2023
@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2023
@alicejli
Copy link
Contributor

failing unit tests for:

2023-08-23T01:25:38.4647718Z 01:25:38:464 [ERROR] com.google.cloud.billing.v1.CloudBillingClientHttpJsonTest.getProjectBillingInfoTest  Time elapsed: 0.031 s  <<< ERROR!
2023-08-23T01:25:38.4648563Z com.google.api.gax.rpc.NotFoundException: 
2023-08-23T01:25:38.4649376Z com.google.api.client.http.HttpResponseException: 404
2023-08-23T01:25:38.4650294Z GET https://cloudbilling.googleapis.com:443/v1/projects/%5BPROJECT%5D/billingInfo/billingInfo?$alt=json;enum-encoding%3Dint
2023-08-23T01:25:38.4651315Z Method not found for path 'https:///v1/projects/%5BPROJECT%5D/billingInfo/billingInfo'

Seems like this test was disabled but then re-enabled for this PR: https://github.com/googleapis/google-cloud-java/pull/9778/files#diff-4af1de055379391075314b9bf10b3b0719cc0267b8728c45298d5506afe039feL479

@lqiu96 Is this the correct regenerated PR or are we waiting on another fix to come?

@alicejli
Copy link
Contributor

The tests should pass once googleapis/sdk-platform-java#1780 is resolved. There will be another owlbot PR containing the fix that should be merged first, then this PR should pass.

@alicejli
Copy link
Contributor

@blakeli0 Do you have a preference if we wait to merge this PR until the fix is submitted, or if I should just manually put the @Ignore annotation back into the test to merge this PR?

PiperOrigin-RevId: 563189185

Source-Link: googleapis/googleapis@4967815

Source-Link: googleapis/googleapis-gen@9f06f3e
Copy-Tag: eyJwIjoiamF2YS1iaWxsaW5nLy5Pd2xCb3QueWFtbCIsImgiOiI5ZjA2ZjNlMGJjMGUxNjY2MmEyNjRlM2RkYzJlZjM5YmY3YWQ5M2VjIn0=
@gcf-owl-bot gcf-owl-bot bot changed the title docs: [cloudbilling] update comments fix: [cloudbilling] fixed resource_reference for name in GetProjectBillingInfo Sep 6, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2023
@snippet-bot
Copy link

snippet-bot bot commented Sep 6, 2023

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2023
@mpeddada1 mpeddada1 merged commit acfa7dc into main Sep 8, 2023
32 checks passed
@mpeddada1 mpeddada1 deleted the owl-bot-copy-java-billing branch September 8, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpJsonTest fails for a singleton resource
3 participants