Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore can return an empty page and still have a next page #1181

Closed
jgeewax opened this issue Mar 23, 2016 · 1 comment
Closed

Datastore can return an empty page and still have a next page #1181

jgeewax opened this issue Mar 23, 2016 · 1 comment
Assignees
@yoshi-automation
Labels
api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Mar 23, 2016

https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/datastore/request.js#L644

I think we need to fix this logic.
@jgeewax jgeewax added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: datastore Issues related to the Datastore API. labels Mar 23, 2016
@stephenplusplus
Copy link
Contributor

This will be fixed with #897.

@stephenplusplus stephenplusplus mentioned this issue Mar 24, 2016
Merged
19 tasks
@jgeewax jgeewax mentioned this issue Apr 5, 2016
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgeewax @stephenplusplus @yoshi-automation