Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata provider for cloud run #5980

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Conversation

bshaffer
Copy link
Contributor

fixes #2785

Adds a MetadataProvider for cloud run

cc @glasnt and @grayside, who can tell me if this is the right approach

@bshaffer bshaffer marked this pull request as ready for review March 22, 2023 20:17
@bshaffer bshaffer requested review from a team as code owners March 22, 2023 20:17
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise

@bshaffer bshaffer added the next release PRs to be included in the next release label Apr 8, 2023
@bshaffer bshaffer merged commit 7fd6408 into main Apr 18, 2023
@bshaffer bshaffer deleted the cloud-run-metadata-provider branch April 18, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorReporting: No "serviceContext" on logs from Cloud Run
2 participants