Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecaptchaEnterpriseServiceClient/search_related_account_group_memberships.php example is wrong #5991

Closed
frankenbubble opened this issue Mar 22, 2023 · 3 comments
Labels
api: recaptchaenterprise Issues related to the reCAPTCHA Enterprise API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@frankenbubble
Copy link

frankenbubble commented Mar 22, 2023

Hi, the example for recaptcha enterprise account defender related groups feature is non functional, seems the generation of the example just needs a tweak

Example given https://github.com/googleapis/google-cloud-php-recaptcha-enterprise/blob/main/samples/V1/RecaptchaEnterpriseServiceClient/search_related_account_group_memberships.php#L71

This example uses the function https://github.com/googleapis/google-cloud-php-recaptcha-enterprise/blob/main/src/V1/Gapic/RecaptchaEnterpriseServiceGapicClient.php#L288

This should be a project name and hashed account ID ( passed as an array of optional arguments) as defined here

https://github.com/googleapis/google-cloud-php-recaptcha-enterprise/blob/main/src/V1/Gapic/RecaptchaEnterpriseServiceGapicClient.php#L1120

@saranshdhingra saranshdhingra added priority: p2 Moderately-important priority. Fix may not be included in next release. api: recaptchaenterprise Issues related to the reCAPTCHA Enterprise API. labels Mar 23, 2023
@saranshdhingra
Copy link
Contributor

I think that makes sense. The sample and the snippet both use the fomattedParent as projects/{project}/relatedaccountgroups/{relatedaccountgroup} while the method expects projects/{project}.

Since this is generated by owlbot, I need to tap in @bshaffer.

@bshaffer
Copy link
Contributor

I do not see an issue related to OwlBot here (OwlBot only copies the code and creates the pull requests, and in some cases modifies generator output which we are actively removing). I see an issue with the code generator, specifically snippet gen.

@saranshdhingra
Copy link
Contributor

I will be closing this issue as we have opened the issue in the gapic generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: recaptchaenterprise Issues related to the reCAPTCHA Enterprise API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

3 participants