Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add universe domain environment variable support to bigquery and storage #6993

Merged
merged 4 commits into from
Feb 16, 2024
Merged

feat: add universe domain environment variable support to bigquery and storage #6993

merged 4 commits into from
Feb 16, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jan 24, 2024 •
edited

  • Tested E2E

bshaffer
bshaffer commented Feb 15, 2024
View reviewed changes
PubSub/composer.json Outdated Show resolved Hide resolved
@bshaffer bshaffer changed the title feat: add support for Universe Domain env var feat: add universe domain environment variable support to bigquery and storage Feb 15, 2024
@bshaffer bshaffer marked this pull request as ready for review February 15, 2024 20:51
@bshaffer bshaffer requested review from a team as code owners February 15, 2024 20:51
vishwarajanand
vishwarajanand approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I ran the System tests in TPC environments and ensured that the Storage and BQ endpoints use a non-default universe domain and perform usual operations as expected.

@bshaffer bshaffer merged commit 528bb62 into main Feb 16, 2024
27 checks passed
@bshaffer bshaffer deleted the add-universe-domain-envvar branch February 16, 2024 20:38
@release-please release-please bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees

@vishwarajanand vishwarajanand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bshaffer @vishwarajanand