Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: [AiPlatform] remove field max_wait_duration from message Scheduling #7052

Merged
merged 3 commits into from Feb 14, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 9, 2024

  • Regenerate this pull request now.

feat: add psc_automated_endpoints to IndexPrivateEndpoints
feat: add request_response_logging_schema_version to ModelDeploymentMonitoringBigQueryTable
feat: add resource_title, resource_use_case, resource_description to RegionalResourceReferences
feat: add deploy_gke, open_tine_tuning_pipelines, open_notebooks to CallToAction
docs: deprecate use_case and description in ResourceReference
docs: minor changes to comments

PiperOrigin-RevId: 605667976

Source-Link: googleapis/googleapis@3b25a48

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b8402de22611a3b7bffa59b075891e5b29a0d554
Copy-Tag: eyJwIjoiQWlQbGF0Zm9ybS8uT3dsQm90LnlhbWwiLCJoIjoiYjg0MDJkZTIyNjExYTNiN2JmZmE1OWIwNzU4OTFlNWIyOWEwZDU1NCJ9

BREAKING_CHANGE_REASON=The breaking change is discussed and approved for release in b/321148432

feat: add psc_automated_endpoints to IndexPrivateEndpoints
feat: add request_response_logging_schema_version to ModelDeploymentMonitoringBigQueryTable
feat: add resource_title, resource_use_case, resource_description to RegionalResourceReferences
feat: add deploy_gke, open_tine_tuning_pipelines, open_notebooks to CallToAction
docs: deprecate use_case and description in ResourceReference
docs: minor changes to comments

PiperOrigin-RevId: 605667976

Source-Link: googleapis/googleapis@3b25a48

Source-Link: googleapis/googleapis-gen@b8402de
Copy-Tag: eyJwIjoiQWlQbGF0Zm9ybS8uT3dsQm90LnlhbWwiLCJoIjoiYjg0MDJkZTIyNjExYTNiN2JmZmE1OWIwNzU4OTFlNWIyOWEwZDU1NCJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review February 9, 2024 20:58
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners February 9, 2024 20:58
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2024
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a BC compat justification

@vishwarajanand
Copy link
Contributor

vishwarajanand commented Feb 14, 2024

A breaking change justification was provided in the CL:
BREAKING_CHANGE_ALLOWED=[b/321148432](http://b/321148432)

I've added it to the PR description manually. @bshaffer can you pls have a look at this again?

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2024
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the breaking change is already discussed and approved, I think this change is good to be.

@bshaffer
Copy link
Contributor

@vishwarajanand I would say that the justification here is that AI Platform is in beta, and they change their API very frequently. In the future, just posting the link to the bug is not sufficient.

@vishwarajanand vishwarajanand enabled auto-merge (squash) February 14, 2024 19:24
@vishwarajanand vishwarajanand merged commit be6fba4 into main Feb 14, 2024
26 checks passed
@vishwarajanand vishwarajanand deleted the owl-bot-copy-AiPlatform branch February 14, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants