-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: [AiPlatform] remove field max_wait_duration
from message Scheduling
#7052
Conversation
feat: add psc_automated_endpoints to IndexPrivateEndpoints feat: add request_response_logging_schema_version to ModelDeploymentMonitoringBigQueryTable feat: add resource_title, resource_use_case, resource_description to RegionalResourceReferences feat: add deploy_gke, open_tine_tuning_pipelines, open_notebooks to CallToAction docs: deprecate use_case and description in ResourceReference docs: minor changes to comments PiperOrigin-RevId: 605667976 Source-Link: googleapis/googleapis@3b25a48 Source-Link: googleapis/googleapis-gen@b8402de Copy-Tag: eyJwIjoiQWlQbGF0Zm9ybS8uT3dsQm90LnlhbWwiLCJoIjoiYjg0MDJkZTIyNjExYTNiN2JmZmE1OWIwNzU4OTFlNWIyOWEwZDU1NCJ9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a BC compat justification
A breaking change justification was provided in the CL: I've added it to the PR description manually. @bshaffer can you pls have a look at this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the breaking change is already discussed and approved, I think this change is good to be.
@vishwarajanand I would say that the justification here is that AI Platform is in beta, and they change their API very frequently. In the future, just posting the link to the bug is not sufficient. |
feat: add psc_automated_endpoints to IndexPrivateEndpoints
feat: add request_response_logging_schema_version to ModelDeploymentMonitoringBigQueryTable
feat: add resource_title, resource_use_case, resource_description to RegionalResourceReferences
feat: add deploy_gke, open_tine_tuning_pipelines, open_notebooks to CallToAction
docs: deprecate use_case and description in ResourceReference
docs: minor changes to comments
PiperOrigin-RevId: 605667976
Source-Link: googleapis/googleapis@3b25a48
Source-Link: https://github.com/googleapis/googleapis-gen/commit/b8402de22611a3b7bffa59b075891e5b29a0d554
Copy-Tag: eyJwIjoiQWlQbGF0Zm9ybS8uT3dsQm90LnlhbWwiLCJoIjoiYjg0MDJkZTIyNjExYTNiN2JmZmE1OWIwNzU4OTFlNWIyOWEwZDU1NCJ9
BREAKING_CHANGE_REASON=The breaking change is discussed and approved for release in b/321148432