Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Storage): softDelete object in gcs buckets #7154

Merged
merged 6 commits into from Mar 18, 2024
Merged

feat(Storage): softDelete object in gcs buckets #7154

merged 6 commits into from Mar 18, 2024

Conversation

vishwarajanand
Copy link
Contributor

As part of the soft delete feature, add support to

  • Set a soft delete policy on a new or existing bucket
  • Get a bucket's soft delete policy
  • Get a soft deleted object with softDeleted => true
  • List soft deleted objects with softDeleted => true
  • Restore a soft deleted object

Fixes #7049

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 15, 2024
@vishwarajanand vishwarajanand marked this pull request as ready for review March 15, 2024 20:42
@vishwarajanand vishwarajanand requested review from a team as code owners March 15, 2024 20:42
ajupazhamayil
ajupazhamayil requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@ajupazhamayil ajupazhamayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some Nit comments, Please resolve them, the src looks good to me. Thanks.

ajupazhamayil
ajupazhamayil approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@ajupazhamayil ajupazhamayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@vishwarajanand vishwarajanand merged commit 09ea3af into googleapis:main Mar 18, 2024
22 checks passed
@release-please release-please bot mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajupazhamayil ajupazhamayil ajupazhamayil approved these changes

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: add soft delete feature
3 participants
@vishwarajanand @ajupazhamayil @JesseLovelace