Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SecretManager): Introduce v1beta2 #7166

Merged
merged 3 commits into from Mar 22, 2024
Merged

feat(SecretManager): Introduce v1beta2 #7166

merged 3 commits into from Mar 22, 2024

Conversation

yash30201
Copy link
Contributor

@yash30201 yash30201 commented Mar 20, 2024 •
edited

Generating this manually as owlbot yaml didn't had the congifuration for v1beta2 and thus we missed owlbot generation.

see b/328549779 for more details

@yash30201 yash30201 requested review from a team as code owners March 20, 2024 02:13
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Mar 20, 2024 •
edited

Here is the summary of changes.

You are about to add 17 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: secretmanager Issues related to the Secret Manager API. label Mar 20, 2024
@yash30201 yash30201 added the next release PRs to be included in the next release label Mar 21, 2024
vishwarajanand
vishwarajanand approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yash30201 yash30201 merged commit c843cee into googleapis:main Mar 22, 2024
21 checks passed
@release-please release-please bot mentioned this pull request Mar 22, 2024
Merged
@yash30201 yash30201 deleted the generate-secretmanager-v1beta2 branch May 8, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees
No one assigned
Labels
api: secretmanager Issues related to the Secret Manager API. next release PRs to be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yash30201 @vishwarajanand