Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce AppsChat #7215

Merged
merged 3 commits into from Apr 16, 2024
Merged

feat: introduce AppsChat #7215

merged 3 commits into from Apr 16, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Apr 11, 2024

b/326631249

Note: The AppsChat package also contains the protos from google/apps/card. This is because:

  • at the moment, there are no other packages which depend on google/apps/card.
  • If there is a time in the future where we deploy another package which relies on google/apps/card, we can create a new package (google/apps-shared-protos) to contain the protos in google/apps/card, and any others which exist at the time.

IF there are other use cases which I am not aware of, where a customer would want to use the protos in google/apps/card without using the AppsChat package, that would be another good reason to split them out now. I'm happy to do so if that's the case, but I wanted to keep this simple for now if we don't have a use-case for doing so.

@bshaffer bshaffer requested review from a team as code owners April 11, 2024 16:44
Copy link

snippet-bot bot commented Apr 11, 2024

Here is the summary of changes.

You are about to add 22 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. It seems logical to have both Google\Apps\Chat\* and Google\Apps\Card\* for now under AppsChat/src folder.

I checked the namespaces they seem correctly defined in composer.json files.

@bshaffer bshaffer merged commit b0c6cc9 into main Apr 16, 2024
24 checks passed
@bshaffer bshaffer deleted the introduce-appschat branch April 16, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants