Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [VideoStitcher] add apis for Create, Read, Update, Delete for VODConfigs #7332

Merged
merged 2 commits into from
May 24, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented May 23, 2024

  • Regenerate this pull request now.

feat: allowed usage for VODConfigs in VODSession
feat: added token config for MediaCdnKey
feat: added targetting parameter support to Livesession
feat: added adtracking to Livesession
feat: added fetchoptions with custom headers for Live and VODConfigs

docs: Added apis for Create, Read, Update, Delete For VODConfigs. Added vodConfig usage in VODSession. Added TokenConfig for MediaCdnKey. Added targeting_parameter and ad_tracking for Livesession. Added FetchOptions for Live and VOD configs.
PiperOrigin-RevId: 636368401

Source-Link: googleapis/googleapis@30717c0

Source-Link: https://github.com/googleapis/googleapis-gen/commit/cc30711ef8e16d4887d19f677b9382df0ae60ed8
Copy-Tag: eyJwIjoiVmlkZW9TdGl0Y2hlci8uT3dsQm90LnlhbWwiLCJoIjoiY2MzMDcxMWVmOGUxNmQ0ODg3ZDE5ZjY3N2I5MzgyZGYwYWU2MGVkOCJ9

BREAKING_CHANGE_REASON=pre-1.0 library, breaking change as a result of a previously-removed message being added back.

feat: allowed usage for VODConfigs in VODSession
feat: added token config for MediaCdnKey
feat: added targetting parameter support to Livesession
feat: added adtracking to Livesession
feat: added fetchoptions with custom headers for Live and VODConfigs

docs: Added apis for Create, Read, Update, Delete For VODConfigs. Added vodConfig usage in VODSession. Added TokenConfig for MediaCdnKey. Added targeting_parameter and ad_tracking for Livesession. Added FetchOptions for Live and VOD configs.
PiperOrigin-RevId: 636368401

Source-Link: googleapis/googleapis@30717c0

Source-Link: googleapis/googleapis-gen@cc30711
Copy-Tag: eyJwIjoiVmlkZW9TdGl0Y2hlci8uT3dsQm90LnlhbWwiLCJoIjoiY2MzMDcxMWVmOGUxNmQ0ODg3ZDE5ZjY3N2I5MzgyZGYwYWU2MGVkOCJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review May 23, 2024 04:03
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners May 23, 2024 04:03
Copy link

snippet-bot bot commented May 23, 2024

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@ajupazhamayil
Copy link
Contributor

Holding the merge as it has a breaking change. I see a previously required parameter GamVodConfig#getStreamId got removed in this PR.

cc: @bshaffer

@bshaffer
Copy link
Contributor

@ajupazhamayil since this is pre-1.0, we can go ahead and merge the breaking change

I took a look at the RevId change, and surprisingly there is no removal of that method in that CL. I imagine it's because the message GamVodConfig was removed in the protos in a previous change, but not in this library (because we don't remove generated classes), and now it was added without the stream_id field.

Either way, I think it's okay to merge this. I've added the BREAKING_CHANGE_REASON

@bshaffer bshaffer enabled auto-merge (squash) May 24, 2024 15:52
@bshaffer bshaffer merged commit 2758508 into main May 24, 2024
26 of 27 checks passed
@bshaffer bshaffer deleted the owl-bot-copy-VideoStitcher branch May 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants