fix: remove unused annotation in results_table #11548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
PiperOrigin-RevId: 553938801 Source-Link: googleapis/googleapis@ff66907 Source-Link: googleapis/googleapis-gen@ee14ddb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRhdGFwbGV4Ly5Pd2xCb3QueWFtbCIsImgiOiJlZTE0ZGRiMWZjOWU5MTliMWEyZTEwYTZjYzAxZTJmODFlMWMzYzQxIn0=
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
approved these changes
Aug 6, 2023
Comment on lines
-271
to
-292
| @staticmethod | ||
| def table_path( | ||
| project: str, | ||
| dataset: str, | ||
| table: str, | ||
| ) -> str: | ||
| """Returns a fully-qualified table string.""" | ||
| return "projects/{project}/datasets/{dataset}/tables/{table}".format( | ||
| project=project, | ||
| dataset=dataset, | ||
| table=table, | ||
| ) | ||
|
|
||
| @staticmethod | ||
| def parse_table_path(path: str) -> Dict[str, str]: | ||
| """Parses a table path into its component segments.""" | ||
| m = re.match( | ||
| r"^projects/(?P<project>.+?)/datasets/(?P<dataset>.+?)/tables/(?P<table>.+?)$", | ||
| path, | ||
| ) | ||
| return m.groupdict() if m else {} | ||
|
|
There was a problem hiding this comment.
This is a breaking change however the methods were only added on July 25th. In b/294420502, there is a note that this method would not have worked because the API only accepts
"//bigquery.googleapis.com/projects/{project}/datasets/{dataset}/tables/{table}" and not "projects/{project}/datasets/{dataset}/tables/{table}". Approving based on the discussions in b/294420502
parthea
approved these changes
Aug 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 553938801
Source-Link: googleapis/googleapis@ff66907
Source-Link: https://github.com/googleapis/googleapis-gen/commit/ee14ddb1fc9e919b1a2e10a6cc01e2f81e1c3c41
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRhdGFwbGV4Ly5Pd2xCb3QueWFtbCIsImgiOiJlZTE0ZGRiMWZjOWU5MTliMWEyZTEwYTZjYzAxZTJmODFlMWMzYzQxIn0=