Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking namespace change #1978

Closed
daspecster opened this issue Jul 12, 2016 · 26 comments
Closed

Tracking namespace change #1978

daspecster opened this issue Jul 12, 2016 · 26 comments
Assignees
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daspecster
Copy link
Contributor

daspecster commented Jul 12, 2016

Here's a place we can track updates to the future changing of the gcloud-python namespace.

This change could break things in the future.


Sub-projects already partially created:

@daspecster daspecster added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: core labels Jul 12, 2016
@theacodes
Copy link
Contributor

Is this in reference to changing to google.cloud?

@daspecster
Copy link
Contributor Author

@jonparrott yup! I wasn't sure if that was finalized or not.

@theacodes
Copy link
Contributor

@jgeewax can confirm, but from what I understand that is the way we want to go.

@daspecster
Copy link
Contributor Author

We will want to update the User-Agent string as well for this right? Are there any other implications to that? i.e. people have that user-agent allowed in their apps/firewall.

@jgeewax
Copy link
Contributor

jgeewax commented Jul 26, 2016

Let's leave the useragent string alone -- we would have a whole heap of stuff to fix if we change that....

Otherwise -- yes, we're definitely going forward with google.cloud as the import path

@dhermes
Copy link
Contributor

dhermes commented Aug 15, 2016

@omaray I held off on grabbing the equivalents for dns, error_reporting, monitoring, resource_manager and translate, but I can do that as well if you like. I'm not sure if underscores are allowed in PyPI package names?

@theacodes
Copy link
Contributor

@dhermes you can use underscores but it's preferable to use - for consistency.

google-cloud-error-reporting reads better than google-cloud-error_reporting, even if the import path is google.cloud.error_reporting.

@dhermes
Copy link
Contributor

dhermes commented Aug 16, 2016

Thanks @jonparrott.

@tseaver @jgeewax @omaray, shall we use google-cloud-core for the code shared by all modules sub-packages?

@tseaver
Copy link
Contributor

tseaver commented Aug 16, 2016

google-cloud-core SGTM.

@dhermes
Copy link
Contributor

dhermes commented Aug 16, 2016

👍 Just created https://pypi.python.org/pypi/google-cloud-core

@dhermes
Copy link
Contributor

dhermes commented Aug 17, 2016

@omaray
Copy link
Contributor

omaray commented Aug 17, 2016

Thanks @dhermes. All sgtm. Not sure if we added speech, vision, and language - but I guess might as well.

@dhermes
Copy link
Contributor

dhermes commented Aug 18, 2016

@omaray Just created https://pypi.python.org/pypi/google-cloud-vision and https://pypi.python.org/pypi/google-cloud-speech

Should it be called google-cloud-language or google-cloud-natural-language?

@tseaver
Copy link
Contributor

tseaver commented Aug 18, 2016

+1 for google-cloud-natural-language.

@omaray
Copy link
Contributor

omaray commented Aug 18, 2016

So Ruby and Node.js called it google-cloud-language:

Example: https://www.npmjs.com/package/@google-cloud/language

It's shorter indeed.

If it's easy to do, let's hold both! I'll check with the team.

@dhermes
Copy link
Contributor

dhermes commented Aug 18, 2016

If it's easy to do, let's hold both! I'll check with the team.

It is easy but that would just be namespace squatting on PyPI; seems like it would be frowned upon. Though on the flipside, non-Google entities squatting on a name with google in it is also probably frowned upon.


I've noticed the Googlers keep calling it Language but that seems to be vague for people not already familiar with the API.

@theacodes
Copy link
Contributor

It's fine to have both google-cloud-language and google-cloud-natural-language as long as you publish a metapackage to one that depends on the other.

(fyi, if we do run into a case where there's someone squatting on our name we can get that resolved).

@dhermes
Copy link
Contributor

dhermes commented Aug 18, 2016

So @jonparrott as packaging wizard your opinion is that I should grab both (a) and we should publish to both (b)?

@theacodes
Copy link
Contributor

Grab both and publish to one, and publish a metapackage to the other. But only if you feel like it's really necessary. I'd say don't. Just go with google-cloud-natural-language. Typically the metapackage magic is only done to deal with legacy stuff (like we'll eventually have to do with oauth2client and google-auth).

@dhermes
Copy link
Contributor

dhermes commented Aug 18, 2016

Cool. Thanks (I love having a packaging authority person to consult with...as an authority). Grabbed https://pypi.python.org/pypi/google-cloud-language and https://pypi.python.org/pypi/google-cloud-natural-language

@dhermes
Copy link
Contributor

dhermes commented Aug 18, 2016

@tseaver @omaray (and anyone else who likes to weigh in) are we a go to grab

  • google-cloud-dns
  • google-cloud-error-reporting
  • google-cloud-monitoring
  • google-cloud-resource-manager
  • google-cloud-translate

i.e. some of these it's unclear if they deserve their own package / are priorities.

@rimey any preference for grabbing google-cloud-monitoring or google-cloud-stackdriver-monitoring or something else (or both, as we did with language / natural-language above)

@tseaver
Copy link
Contributor

tseaver commented Aug 19, 2016

I think those are fine. AFAICT, the -stackdriver bit should be a replacement for -cloud if we are going to use it: (the branding seems confused to me).

@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2016

@rimey and @omaray can you weigh in as well?

@omaray
Copy link
Contributor

omaray commented Aug 22, 2016

Yeah, so the whole Stackdriver branding can indeed be confusing. I need to get back to you on that one. For the time being, everything will be google-cloud-{api}.

@omaray
Copy link
Contributor

omaray commented Sep 1, 2016

Yes, confirmed. We are sticking with google-cloud-{api}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

6 participants