Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI testing of 'requester_pays' / 'user_project' feature #4126

Closed
tseaver opened this issue Oct 5, 2017 · 8 comments
Closed

Enable CI testing of 'requester_pays' / 'user_project' feature #4126

tseaver opened this issue Oct 5, 2017 · 8 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. testing type: process A process-related concern. May include testing, release, or the like.
Projects

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 5, 2017

Update .circleci/config.yml to set the GOOGLE_CLOUD_TESTS_USER_PROJECT environment variable to point at a different project than the default one supplied by our credentials.

Until then, the system tests for user_project / requester_pays will be skipped.

Note that #4125 will cause system test failures, so we should defer this task until the back-end team releases their fix.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. testing labels Oct 5, 2017
@dhermes
Copy link
Contributor

dhermes commented Oct 5, 2017

@tseaver We should set env. variables in the project settings, not in .circleci/config.yml

@tseaver
Copy link
Contributor Author

tseaver commented Oct 5, 2017

Ah, thanks for clarification.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 9, 2017

@lukesneeringer In order to start using the 'gcloud-....-whitelist-not-really' project for CI, we need to either: a> grant our existing CI system account the appropriate permissions on the new project; or b) create a new system account with appropriate permissions, and then re-do our system tests so that they use those creds. I would prefer a), as it would let the tests as-written just work.

@tseaver tseaver added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Nov 2, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Jan 8, 2018

#4125 is now closed: the tests run cleanly for me locally, when I set GOOGLE_CLOUD_TESTS_USER_PROJECT to point at my "private" project (running with the "normal" CI account as the main one).

@tseaver
Copy link
Contributor Author

tseaver commented Jan 8, 2018

@lukesneeringer I think we're ready to configure the "user project" to be used as the user_project for those tests under CI. I can't recall which one we agreed to use, though: if you'll follow up here to let me know, I will create a PR updating the CircleCI config to set it.

Note that the service account as which we normally run will need to be configured with the 'project.editor' role on the new one.

@chemelnucfin chemelnucfin added the type: process A process-related concern. May include testing, release, or the like. label Jan 9, 2018
@chemelnucfin chemelnucfin added this to To Do in P2 Bugs Feb 26, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 8, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Jul 20, 2018

@theacodes, @JustinBeckwith can one of your set up a second project with the project.editor role assigned to our CI project? We will then need to set that project in the CI environment as GOOGLE_CLOUD_TESTS_USER_PROJECT, at which point those system tests will no longer be skipped.

@tseaver tseaver removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 25, 2018
@crwilcox
Copy link
Contributor

@tseaver is this still needed?

@busunkim96
Copy link
Contributor

Closing as this seems obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. testing type: process A process-related concern. May include testing, release, or the like.
Projects
No open projects
P2 Bugs
  
To Do
Development

No branches or pull requests

7 participants