Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core test failure on AppVeyor #4128

Closed
tseaver opened this issue Oct 5, 2017 · 3 comments
Closed

Core test failure on AppVeyor #4128

tseaver opened this issue Oct 5, 2017 · 3 comments
Assignees

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 5, 2017

From https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.2336.storage-requester_pays-feature/job/9utfru14kenb40tr

_______________ test_wrap_method_with_overriding_retry_deadline _______________
Traceback (most recent call last):
  File "C:\projects\google-cloud-python\core\tests\unit\api_core\gapic\test_method.py", line 159, in test_wrap_method_with_overriding_retry_deadline
    assert timeout_args == [5, 10, 20, 29]
AssertionError: assert [5.0, 10.0, 20.0, 30.0] == [5, 10, 20, 29]
  At index 3 diff: 30.0 != 29
  Full diff:
  - [5.0, 10.0, 20.0, 30.0]
  + [5, 10, 20, 29]
@dhermes
Copy link
Contributor

dhermes commented Oct 5, 2017

Seems like a float / int division error?

@tseaver
Copy link
Contributor Author

tseaver commented Oct 5, 2017

The assertion itself is problematic: those numbers look suspiciously like "copy what the code actually output," rather than being intrinsically meaningful.

@dhermes dhermes changed the title Core test failure on Appveyour Core test failure on AppVeyor Oct 5, 2017
@dhermes
Copy link
Contributor

dhermes commented Oct 5, 2017

(ASIDE: @tseaver I'm not sure if the AppVeyor folks are brits, but I changed the spelling from Appveyour 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants