Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google.api_core.gapic_v2.client_info #4225

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Add google.api_core.gapic_v2.client_info #4225

merged 2 commits into from
Oct 20, 2017

Conversation

theacodes
Copy link
Contributor

Resolves #4068

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2017
@theacodes
Copy link
Contributor Author

@lukesneeringer @dhermes this is my attempt to fix #4068 without making myself angry. I'm open to feedback and suggestions at alternatives.

lukesneeringer
lukesneeringer reviewed Oct 19, 2017
View reviewed changes
api_core/google/api_core/gapic_v1/client_info.py Outdated
Args:
python_version (str): The Python interpreter version, for example,
``'2.7.13'``.
grpc_version (st): The gRPC library version.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer
lukesneeringer reviewed Oct 19, 2017
View reviewed changes
api_core/google/api_core/gapic_v1/client_info.py Outdated
``'2.7.13'``.
grpc_version (st): The gRPC library version.
api_core_version (str): The google-api-core library version.
gapic_version (Optional[str]): The version of gapic used to generate

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer
lukesneeringer approved these changes Oct 19, 2017
View reviewed changes
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the two nits. I can fix the nits if you like (I will in a few minutes if you do not get to it first.)

@theacodes theacodes merged commit c2d496a into googleapis:master Oct 20, 2017
@theacodes theacodes deleted the api-core-metrics branch October 20, 2017 19:05
@theacodes theacodes added this to Done in google.api.core Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
No open projects
google.api.core
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theacodes @lukesneeringer @googlebot