Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bare except lint error #4250

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix bare except lint error #4250

merged 1 commit into from
Oct 24, 2017

Conversation

theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2017
@theacodes theacodes mentioned this pull request Oct 24, 2017
Merged
dhermes
dhermes approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though Pylint will also dislike this as over-broad

@theacodes
Copy link
Contributor Author

I turned off pylint.

@dhermes
Copy link
Contributor

dhermes commented Oct 24, 2017

I turned off pylint.

I know, I'm just pointing it out.

@theacodes theacodes merged commit 54b3c98 into googleapis:master Oct 24, 2017
@theacodes theacodes deleted the fix-lint branch October 24, 2017 22:54
parthea pushed a commit that referenced this pull request Oct 21, 2023
@Larittic-GG @busunkim96
feat: add sample code for ListAssets v1p5beta1 [(#4251)](GoogleCloudP…
d1feaef 
…latform/python-docs-samples#4251)

## Description

Fixes #4250

Note: It's a good idea to open an issue first for discussion.

## Checklist
- [x] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md)
- [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file)
- [x] **Tests** pass:   `nox -s py-3.6` (see [Test Enviroment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup))
- [x] **Lint** pass:   `nox -s lint` (see [Test Enviroment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
- [x] Please **merge** this PR for me once it is approved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theacodes @dhermes @googlebot