Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gapic_v1.method.wrap_with_paging #4257

Merged
merged 1 commit into from Oct 25, 2017
Merged

Remove gapic_v1.method.wrap_with_paging #4257

merged 1 commit into from Oct 25, 2017

Conversation

theacodes
Copy link
Contributor

Closes #4233

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2017
dhermes
dhermes approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I love deletes!

Why did this need to happen?

@theacodes
Copy link
Contributor Author

Why did this need to happen?

Turns out we didn't need this functionality in the first place. I originally added it for parity with gax, as when gax wrapped methods it would also handle wrapping the response with a page iterator. While exploring changing the generator to use api_core, @landrito and I noticed that methods that return operations just construct the operation in the generated method body, so we saw no reason why we couldn't do the same with page iterators.

@theacodes theacodes merged commit 380697d into googleapis:master Oct 25, 2017
@theacodes theacodes deleted the remove-wrap-with-paging branch October 25, 2017 22:48
@theacodes theacodes added this to Done in google.api.core Oct 26, 2017
parthea pushed a commit that referenced this pull request Jun 4, 2023
@leahecole @busunkim96
cleanup(jobs): remove unnecessary code [(#4257)](GoogleCloudPlatform/…
ba5bbe8 
…python-docs-samples#4257)

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
No open projects
google.api.core
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theacodes @dhermes @googlebot