Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing grpc extra in api-core dependency #4764

Merged
merged 1 commit into from Jan 19, 2018
Merged

Fix missing grpc extra in api-core dependency #4764

merged 1 commit into from Jan 19, 2018

Conversation

theacodes
Copy link
Contributor

No description provided.

@theacodes theacodes added packaging api: clouderrorreporting Issues related to the Error Reporting API. labels Jan 19, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2018
@theacodes theacodes changed the title Fix missing extra in api-core dependency Fix missing grpc extra in api-core dependency Jan 19, 2018
@chemelnucfin
Copy link
Contributor

@jonparrott LGTM

@chemelnucfin
Copy link
Contributor

I see others with just google-api-core though?
Do others need to be fixed?

@theacodes
Copy link
Contributor Author

I see others with just google-api-core though?
Do others need to be fixed?

Not at the moment, these were actually causing test failures.

@theacodes theacodes merged commit 9282fd8 into master Jan 19, 2018
@theacodes theacodes deleted the fix-missing-extra branch January 19, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waprin waprin Awaiting requested review from waprin

Assignees
No one assigned
Labels
api: clouderrorreporting Issues related to the Error Reporting API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theacodes @chemelnucfin @googlebot