Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add timeout parameter to connection's api_request() method #9914

Closed
plamut opened this issue Dec 4, 2019 · 2 comments · Fixed by #9915
Closed

Core: Add timeout parameter to connection's api_request() method #9914

plamut opened this issue Dec 4, 2019 · 2 comments · Fixed by #9915
Assignees
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@plamut
Copy link
Contributor

plamut commented Dec 4, 2019

As a client library developer, I want to have an easy way of specifying the timeout at the transport level for HTTP requests.

Motivation:
If the transport layer makes an HTTP request that gets stalled, it can block the client. Any timeouts and retries on top of it cannot come into play, because the transport layer blocks them while waiting for the response without any timeout specified.

One of the manifestations of the problem in the BigQuery client: #7831

@plamut plamut added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: core labels Dec 4, 2019
@plamut plamut self-assigned this Dec 4, 2019
@tswast
Copy link
Contributor

tswast commented Dec 4, 2019

We’ll want to cut a release for this. Do you have releasetool setup, @plamut ?

@plamut
Copy link
Contributor Author

plamut commented Dec 4, 2019

@tswast I have the tool, last used in September IIRC to release a PubSub client. I can start releasing Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants