Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger Railtie raises exception if project id missing #1410

Closed
hxiong388 opened this issue Apr 7, 2017 · 0 comments · Fixed by #1411
Closed

Debugger Railtie raises exception if project id missing #1410

hxiong388 opened this issue Apr 7, 2017 · 0 comments · Fixed by #1411
Assignees
@hxiong388
Labels
api: clouddebugger Issues related to the Cloud Debugger API.

Comments

@hxiong388
Copy link
Contributor

The current Google::Cloud::Debugger::Railtie initialization procedure raises an exception if a GCP project id isn't provided through environment variable or Rails configuration while running from non-GCP environments.

Ideally, the Google::Cloud::Debugger::Railtie should behave similarly to the other Stackdriver Railties. It should log an warning message explaining the Debugger Railtie initialization failed due to missing project id, and not interrupt the Rails application from starting.
@hxiong388 hxiong388 added the api: clouddebugger Issues related to the Cloud Debugger API. label Apr 7, 2017
@hxiong388 hxiong388 self-assigned this Apr 7, 2017
@hxiong388 hxiong388 mentioned this issue Apr 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hxiong388 hxiong388

Labels
api: clouddebugger Issues related to the Cloud Debugger API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Debugger::Railtie doesn't stop Rails from starting up hxiong388/google-cloud-ruby
1 participant
@hxiong388