feat(spanner): benchwrapper and proto updated. #16152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajajneha27
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
dazuma
approved these changes
Dec 7, 2021
| client.commit do |c| | ||
| c.insert "sometable", insert_query.users.map { |user| {name: user.name, age: user.age} } | ||
| @client.commit do |c| | ||
| c.insert "Singers", insert_query.singers.map { |singer| {SingerId: singer.id, FirstName: singer.first_name, LastName: singer.last_name} } |
There was a problem hiding this comment.
Break up this line a bit for readability. (The hash inside the map block could be split onto multiple lines, and maybe create a temporary local variable for the result of the map call so the block isn't syntactically ambiguous regarding whether it belongs with map or insert.)
bajajneha27
force-pushed
the
spanner/benchwrapper
branch
from
910fe24
to
1aadc69
Compare
zoercai
approved these changes
Dec 10, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### 2.11.0 / 2021-12-10 #### Features * add admin instance wrapper ([#16080](https://www.github.com/googleapis/google-cloud-ruby/issues/16080)) * Updated benchwrapper and proto for spanner. ([#16152](https://www.github.com/googleapis/google-cloud-ruby/issues/16152)) * use gRPC clients for instance/database management ([#13157](https://www.github.com/googleapis/google-cloud-ruby/issues/13157)) * wrapper to create generated admin database client. ([#13456](https://www.github.com/googleapis/google-cloud-ruby/issues/13456)) --- ### Commits since last release: * [feat(spanner): Updated benchwrapper and proto for spanner. (#16152)](c67d621) * [feat(spanner): use gRPC clients for instance/database management (#13157)](b6fdf2f) * [feat(spanner): add admin instance wrapper (#16080)](d26c9c9) * [feat(spanner): wrapper to create generated admin database client. (#13456)](24bf835) ### Files edited since last release: <pre><code>google-cloud-spanner/benchmark/benchwrapper/benchwrapper.rb google-cloud-spanner/benchmark/benchwrapper/spanner.proto google-cloud-spanner/benchmark/benchwrapper/spanner_pb.rb google-cloud-spanner/benchmark/benchwrapper/spanner_services_pb.rb google-cloud-spanner/OVERVIEW.md google-cloud-spanner/README.md google-cloud-spanner/lib/google/cloud/spanner/backup.rb google-cloud-spanner/lib/google/cloud/spanner/backup/job.rb google-cloud-spanner/lib/google/cloud/spanner/backup/job/list.rb google-cloud-spanner/lib/google/cloud/spanner/backup/list.rb google-cloud-spanner/lib/google/cloud/spanner/backup/restore/job.rb google-cloud-spanner/lib/google/cloud/spanner/database.rb google-cloud-spanner/lib/google/cloud/spanner/database/backup_info.rb google-cloud-spanner/lib/google/cloud/spanner/database/job.rb google-cloud-spanner/lib/google/cloud/spanner/database/job/list.rb google-cloud-spanner/lib/google/cloud/spanner/database/list.rb google-cloud-spanner/lib/google/cloud/spanner/database/restore_info.rb google-cloud-spanner/lib/google/cloud/spanner/instance.rb google-cloud-spanner/lib/google/cloud/spanner/instance/config.rb google-cloud-spanner/lib/google/cloud/spanner/instance/config/list.rb google-cloud-spanner/lib/google/cloud/spanner/instance/job.rb google-cloud-spanner/lib/google/cloud/spanner/instance/list.rb google-cloud-spanner/lib/google/cloud/spanner/project.rb google-cloud-spanner/acceptance/instance_client_test.rb google-cloud-spanner/lib/google/cloud/spanner/admin/instance.rb google-cloud-spanner/test/google/cloud/spanner/admin/instance/client_config_test.rb google-cloud-spanner/test/google/cloud/spanner/admin/instance/client_test.rb google-cloud-spanner/acceptance/spanner/database_client_test.rb google-cloud-spanner/lib/google/cloud/spanner/admin/database.rb google-cloud-spanner/test/google/cloud/spanner/admin/database/client_config_test.rb google-cloud-spanner/test/google/cloud/spanner/database/client_test.rb </code></pre> [Compare Changes](8b1d497...HEAD) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
bundle exec rake ciin the gem subdirectory.