Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(google-cloud-storage): support OLM Prefix/Suffix #18190

Merged
merged 20 commits into from
Jun 30, 2022
Merged

feat(google-cloud-storage): support OLM Prefix/Suffix #18190

merged 20 commits into from
Jun 30, 2022

Conversation

SandeepTuniki
Copy link
Contributor

@SandeepTuniki SandeepTuniki commented May 4, 2022 •
edited

Implements #17985

Tests are not expected to pass until the feature is released. The feature is released now, so the tests should pass.

@SandeepTuniki SandeepTuniki added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 4, 2022
@SandeepTuniki SandeepTuniki requested review from a team as code owners May 4, 2022 10:40
@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022
@shaffeeullah
Copy link

@SandeepTuniki , tests should be passing now. can you please confirm?

@SandeepTuniki
Copy link
Contributor Author

SandeepTuniki commented Jun 2, 2022 •
edited

@shaffeeullah There's a bug in my code which needs to be fixed. Let me solve it and get back to you.

@shaffeeullah
Copy link

@SandeepTuniki this feature has been released and this PR can be merged when it's ready

@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2022
@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2022
@SandeepTuniki SandeepTuniki added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2022
@SandeepTuniki SandeepTuniki removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 14, 2022
@SandeepTuniki
Copy link
Contributor Author

The bug is fixed now (cc: @shaffeeullah). This PR is ready for review.

The failing acceptance test case is failing for main branch too. It is being tracked at #18342

dazuma
dazuma approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bajajneha27
bajajneha27 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2022
@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2022
@SandeepTuniki SandeepTuniki mentioned this pull request Jun 28, 2022
Merged
@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@SandeepTuniki SandeepTuniki merged commit baaf41f into main Jun 30, 2022
@SandeepTuniki SandeepTuniki deleted the lifecycle-prefix-suffix branch June 30, 2022 06:03
This was referenced Jun 30, 2022
Merged
Merged
@SandeepTuniki SandeepTuniki mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma dazuma approved these changes

@bajajneha27 bajajneha27 bajajneha27 approved these changes

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SandeepTuniki @shaffeeullah @dazuma @bajajneha27 @yoshi-kokoro