feat(google-cloud-datastore): Add support for operators "!=", "in" and "not_in" in datastore #18401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandeepTuniki
changed the title
This reverts commit 6038279.
|
The failing unit tests are related to the minitest regression. Need to fix them separately for Datastore. |
dazuma
requested changes
Jun 23, 2022
There was a problem hiding this comment.
If you don't want to fix the minitest regression first, try setting the environment variable MT_KWARGS_HACK to 1 during the test (and then unsetting it afterward so it doesn't interfere with tests for other libraries). You should be able to do that in the :ci rake task; just use an ensure block to make sure it gets unset afterward. That should (we hope) revert to the old minitest behavior for this library's tests. (Also, of course include a comment saying why it's there and that it should be removed when the tests are fixed.)
NivedhaSenthil
approved these changes
Jun 27, 2022
dazuma
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: http://b/235907386 (internal)