feat(spanner): Support fine grained access control #19067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- let user create client with database role
bajajneha27
reviewed
Aug 24, 2022
| @@ -277,8 +277,7 @@ def can_allocate_more_sessions? | |||
| end | |||
|
|
|||
| def create_keepalive_task! | |||
| @keepalive_task = Concurrent::TimerTask.new(execution_interval: 300, | |||
| timeout_interval: 60) do | |||
| @keepalive_task = Concurrent::TimerTask.new execution_interval: 300 do | |||
There was a problem hiding this comment.
Why are we removing timeout_interval ?
There was a problem hiding this comment.
timeout_interval is not taken into account by concurrent_ruby now https://github.com/ruby-concurrency/concurrent-ruby/blob/4cfc0a107b10d3ab213396d53411a1ee487200af/lib/concurrent-ruby/concurrent/timer_task.rb#L268 .. using it puts a lot of unnecessary warnings when running tests
There was a problem hiding this comment.
Got it, thanks. Can we just add a comment here for that?
Overall LGTM
There was a problem hiding this comment.
I would prefer adding it in the commit description when merging,
As we are anyways removing the option. Does that sound fine ?
dazuma
approved these changes
Aug 30, 2022
google-cloud-spanner/acceptance/spanner/fine_grain_access_control_test.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/acceptance/spanner/fine_grain_access_control_test.rb
Outdated
Show resolved
Hide resolved
bajajneha27
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
bundle exec rake ciin the gem subdirectory.closes: #<issue_number_goes_here>