Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Update all patch bucket helper methods to accept preconditions #19117

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

bajajneha27
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #<issue_number_goes_here>

@bajajneha27 bajajneha27 requested review from a team as code owners September 6, 2022 16:14
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 6, 2022
@bajajneha27
Copy link
Contributor Author

The acceptance test failures are flaky and are being tracked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants