Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add retry support for non-idempotent operations #19134

Merged
merged 5 commits into from
Sep 14, 2022
Merged

feat(storage): add retry support for non-idempotent operations #19134

merged 5 commits into from
Sep 14, 2022

Conversation

SandeepTuniki
Copy link
Contributor

@SandeepTuniki SandeepTuniki commented Sep 8, 2022 •
edited

Fixes: http://b/232351537 (internal)

This PR implements support for non-idempotent retry operations for Storage. It sets the default value of retries to 0, but gives the user option to override it.

Implements the retry option for the following operations:

  • storage.hmacKey.create
  • storage.notifications.insert
  • storage.bucket_acl.insert
  • storage.bucket_acl.delete
  • storage.default_object_acl.delete
  • storage.default_object_acl.insert
  • storage.object_acl.delete
  • storage.object_acl.insert

@SandeepTuniki SandeepTuniki requested review from a team as code owners September 8, 2022 09:08
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 8, 2022
@SandeepTuniki SandeepTuniki mentioned this pull request Sep 8, 2022
Closed
@SandeepTuniki SandeepTuniki changed the title feat(storage): add support for non-idempotent operations feat(storage): add retry support for non-idempotent operations Sep 8, 2022
@SandeepTuniki SandeepTuniki mentioned this pull request Sep 8, 2022
Merged
bajajneha27
bajajneha27 requested changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM
Please also implement storage.default_object_acl.delete , storage.default_object_acl.insert , storage.object_acl.delete , storage.object_acl.insert also

@SandeepTuniki
Copy link
Contributor Author

Please also implement storage.default_object_acl.delete , storage.default_object_acl.insert , storage.object_acl.delete , storage.object_acl.insert also

@bajajneha27 I added the retry options for these methods too.

@SandeepTuniki SandeepTuniki merged commit 7f5b321 into main Sep 14, 2022
@SandeepTuniki SandeepTuniki deleted the storage-non-idempotent-retries branch September 14, 2022 10:50
@yoshi-code-bot yoshi-code-bot mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SandeepTuniki @bajajneha27