feat(datastore): Support query count for Datastore #20039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
SandeepTuniki
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
SandeepTuniki
changed the title
dazuma
requested changes
Jan 23, 2023
google-cloud-datastore/lib/google/cloud/datastore/aggregate_query.rb
Outdated
Show resolved
Hide resolved
google-cloud-datastore/lib/google/cloud/datastore/aggregate_query.rb
Outdated
Show resolved
Hide resolved
google-cloud-datastore/lib/google/cloud/datastore/dataset/aggregate_query_results.rb
Outdated
Show resolved
Hide resolved
|
@dazuma I addressed all the comments and made the changes. Can you review this PR again please? |
dazuma
approved these changes
Feb 1, 2023
google-cloud-datastore/lib/google/cloud/datastore/dataset/aggregate_query_results.rb
Outdated
Show resolved
Hide resolved
SandeepTuniki
force-pushed
the
datastore-query-count
branch
from
fd1fc84
to
729c1f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Datastore's Aggregate Query Count feature.
Similar implementation for Firestore has been done previously in #19457