Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): Change "aggregate_alias" to optional param #20082

Merged
merged 2 commits into from Feb 2, 2023

Conversation

SandeepTuniki
Copy link
Contributor

This Firestore PR is a follow up to the discussion in a related Datastore PR i.e; #20039 (comment). The parameter aggregate_alias param is made optional to facilitate easier access of a single-aggregate query responses.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jan 25, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@SandeepTuniki SandeepTuniki changed the title fix(google-cloud-firestore): Change "aggregate_alias" to optional param fix(firestore): Change "aggregate_alias" to optional param Jan 25, 2023
@SandeepTuniki SandeepTuniki marked this pull request as ready for review January 25, 2023 13:29
@SandeepTuniki SandeepTuniki requested a review from a team as a code owner January 25, 2023 13:29
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jan 27, 2023
@SandeepTuniki SandeepTuniki merged commit 99b1c2b into main Feb 2, 2023
@SandeepTuniki SandeepTuniki deleted the firestore-count-api-change branch February 2, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants