Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add json type support #24491

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Conversation

NivedhaSenthil
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #20518

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jan 29, 2024
Copy link
Contributor

@shivgautam shivgautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shivgautam
Copy link
Contributor

@NivedhaSenthil - Do we need to add samples for JSON usage or is the code documentation sufficient?

@NivedhaSenthil
Copy link
Member Author

There is no region tag I could find and the doc doesn't seem to have samples too https://cloud.google.com/bigquery/docs/json-data

@NivedhaSenthil NivedhaSenthil merged commit caf4be1 into main Feb 2, 2024
14 checks passed
@NivedhaSenthil NivedhaSenthil deleted the bigquery_json_type branch February 2, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: support for JSON data type
2 participants