chore: Resolve BigDecimal warnings #26012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowmage
changed the title
blowmage
commented
May 31, 2024
blowmage
commented
May 31, 2024
| @@ -19,8 +19,9 @@ Gem::Specification.new do |gem| | |||
|
|
|||
| gem.required_ruby_version = ">= 2.7" | |||
|
|
|||
| gem.add_dependency "bigdecimal", "~> 3.0" | |||
| gem.add_dependency "concurrent-ruby", "~> 1.0" | |||
There was a problem hiding this comment.
This gem moved lines so all gem dependencies would be sorted by name.
blowmage
commented
May 31, 2024
blowmage
force-pushed
the
fix/bigdecimal-require
branch
from
45d1e58
to
2964382
Compare
Add bigdecimal dependency to BigQuery gemspec.
Resolves the following warning:
warning: bigdecimal was loaded from the standard library,
but will no longer be part of the default gems since Ruby 3.4.0.
Add bigdecimal to your Gemfile or gemspec.
Reference-to: googleapis#25461
Add bigdecimal dependency to Firestore gemspec.
Resolves the following warning:
warning: bigdecimal was loaded from the standard library,
but will no longer be part of the default gems since Ruby 3.4.0.
Add bigdecimal to your Gemfile or gemspec.
Reference-to: googleapis#25461
Add bigdecimal dependency to PubSub Gemfile.
Resolves the following warning:
warning: bigdecimal was loaded from the standard library,
but will no longer be part of the default gems since Ruby 3.4.0.
Add bigdecimal to your Gemfile or gemspec.
Reference-to: googleapis#25461
blowmage
force-pushed
the
fix/bigdecimal-require
branch
from
2964382
to
a8b8a7a
Compare
dazuma
approved these changes
Jun 4, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the gemspecs to add an explicit dependency on the bigdecimal gem for all gems that call
require "bigdecimal". This resolves the following warning:closes: #25461