Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): database backup and restore #5053

Merged
merged 4 commits into from
Mar 20, 2020
Merged

feat(spanner): database backup and restore #5053

merged 4 commits into from
Mar 20, 2020

Conversation

jiren
Copy link
Member

@jiren jiren commented Mar 18, 2020 •
edited
Loading

Towards: #5068 and #5070

APIs:

  • Backup CRUD, cancel create operation
  • Backup list
  • Backup operations
  • Database operations
  • Backup restore

@jiren jiren added the api: spanner Issues related to the Spanner API. label Mar 18, 2020
@jiren jiren requested a review from skuruppu March 18, 2020 11:49
@jiren jiren self-assigned this Mar 18, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2020
skuruppu
skuruppu approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for working on this PR.

google-cloud-spanner/lib/google/cloud/spanner/backup.rb Outdated Show resolved Hide resolved
hengfengli
hengfengli approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiren jiren added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 19, 2020
@jiren jiren removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 19, 2020
@skuruppu skuruppu merged commit dd228d5 into googleapis:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu skuruppu approved these changes

Assignees

@jiren jiren

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jiren @hengfengli @skuruppu @googlebot