Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add protoc plugin to generate tests #122

Merged
merged 32 commits into from
Jan 25, 2023
Merged

feat: Add protoc plugin to generate tests #122

merged 32 commits into from
Jan 25, 2023

Conversation

averikitsch
Copy link
Contributor

No description provided.

@averikitsch averikitsch requested a review from a team as a code owner January 19, 2023 23:32
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-java API. label Jan 19, 2023
@averikitsch averikitsch force-pushed the snowpea-plugin branch 4 times, most recently from decd773 to eaa0918 Compare January 20, 2023 18:30
meltsufin
meltsufin approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very reasonable to me!

@blakeli0 you might be interested in taking a look, as this is a mini-generator that's using protoc directly. There's also use of Velocity templates to generate tests.

tools/build.sh
# --experimental_allow_proto3_optional \
# $proto_src
echo "# - validation tests"
$PROTOC_PATH \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered using the Xolstice protobuf-maven-plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we are trying to minimize any additional dependencies and rely on tools that have long term maintenance plans.

Base automatically changed from snowpea-build to main January 24, 2023 00:46
grayside
grayside approved these changes Jan 24, 2023
View reviewed changes
.github/workflows/test_generation.yaml Outdated Show resolved Hide resolved
protoc-gen-java-snowpea/README.md Outdated Show resolved Hide resolved
protoc-gen-java-snowpea/README.md Show resolved Hide resolved
protoc-gen-java-snowpea/src/main/resources/classTemplate.vm Show resolved Hide resolved
tools/build.sh Show resolved Hide resolved
tools/build.sh Show resolved Hide resolved
@grayside grayside mentioned this pull request Jan 24, 2023
Merged
@averikitsch averikitsch mentioned this pull request Jan 25, 2023
Closed
@averikitsch averikitsch merged commit 0043e40 into main Jan 25, 2023
@averikitsch averikitsch deleted the snowpea-plugin branch January 25, 2023 00:07
@release-please release-please bot mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside approved these changes

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-java API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averikitsch @grayside @meltsufin