Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should an explicit dependency on google-auth be added? #180

Open
crwilcox opened this issue Sep 29, 2020 · 1 comment
Open

Should an explicit dependency on google-auth be added? #180

crwilcox opened this issue Sep 29, 2020 · 1 comment
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Collaborator

crwilcox commented Sep 29, 2020 •
edited

It seems we don't currently have an explicit dependency on google-auth, though testing requires it. I reverted a change I made as part of async work, but am making this issue to consider further discussion on this. I am guessing we have a use or resumable media that isn't using google-auth?

13ede91
@crwilcox crwilcox changed the title Explicit dependency on google-auth Should an explicit dependency on google-auth be added? Sep 29, 2020
@crwilcox crwilcox added the type: question Request for information or clarification. Not an issue. label Sep 29, 2020
@crwilcox
Copy link
Collaborator Author

To be clear, I can't find a non-transitive use, but it is basically required as part of credentialing. This may not be an error at all, but wanted to raise it as a point of discussion in case anyone had opinions.

@crwilcox crwilcox mentioned this issue Sep 30, 2020
Merged
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label Mar 4, 2021
@cojenco cojenco added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Sep 20, 2022
@meredithslota meredithslota added type: process A process-related concern. May include testing, release, or the like. and removed type: question Request for information or clarification. Not an issue. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crwilcox @meredithslota @cojenco